Jeff Davis <pgsql@j-davis.com> wrote:
> On Mon, 2011-01-31 at 07:26 -0600, Kevin Grittner wrote:
>>> And why are you reading the infomask directly? Do the existing
>>> visibility functions not suffice?
>>
>> It's possible we re-invented some code somewhere, but I'm not
>> clear on what code from this patch might use what existing
>> function. Could you provide specifics?
>
> In CheckForSerializableConflictOut(), it takes a boolean "valid".
Ah, now I see what you're talking about. Take a look at where that
"valid" flag come from -- the CheckForSerializableConflictOut are
all place right after calls to HeapTupleSatisfiesVisibility. The
"valid" value is what HeapTupleSatisfiesVisibility returned. Is it
possible that the hint bits will not be accurate right after that?
With that in mind, do you still see a problem with how things are
currently done?
-Kevin