On July 24, 2015 7:57:43 PM GMT+02:00, Peter Geoghegan <pg@heroku.com> wrote:
>On Fri, Jul 24, 2015 at 2:58 AM, Andres Freund <andres@anarazel.de>
>wrote:
>> I've pushed a version of your patch. I just opted to remove
>p_is_update
>> instead of allowing both to be set at the same time. To me that
>seemed
>> simpler.
>
>I would be hesitant to remove a struct field from a struct that
>appears as a hook argument. Someone's extension (that uses parser
>hooks) might have been relying on that. Perhaps not a big deal.
They'd also be affected by the change in meaning...
---
Please excuse brevity and formatting - I am writing this on my mobile phone.