Re: Database selector

On 28.12.2010 19:01, Guillaume Lelarge wrote:
> Le 28/12/2010 18:41, Erwin Brandstetter a écrit :
>> On 29.10.2010 08:21, Guillaume Lelarge wrote:
>>> Le 28/10/2010 00:33, Dave Page a écrit :
>>>> On Thu, Oct 28, 2010 at 5:25 AM, Guillaume Lelarge
>>>> <guillaume@lelarge.info>   wrote:
>>>>> Dave, Magnus, any opinion on this?
>>>>>
>>>>> It sure isn't a lot of code, and one can think it is a bugfix. Not
>>>>> really my opinion, but I don't object to apply it on 1.12.
>>>>>
>>>>> FYI:
>>>>>    http://code.pgadmin.org/trac/ticket/232
>>>>>
>>>>> http://github.com/gleu/pgadmin3/commit/8c358a7ead668bc7b2f7c845ab83b4b3c8f4d1aa
>>>>>
>>>> I think we can consider it a bug. It may not actually be a crash or
>>>> anything, but it's certainly a UI design issue.
>>>>
>>> Done.
>> I did some checks on fixes for 1.12.2 and found that this does not seem
>> to be in the new version .. ?
>>
> It should be. It is in the CHANGELOG:
>
> 2010-10-28 GL  1.12.2  Select old values when connecting to another server.
>
> and on git:
>
> commit 9cb216f9a67838e041e65fd0f9fead425cdfe8b1
> Author: Guillaume Lelarge<guillaume@lelarge.info>
> Date:   Thu Sep 9 23:26:23 2010 +0200
>
>      Select old values when connecting to another server
>
>      When a user selects another server, the database and user comboboxes are
>      cleared and filled again with the new values. The last selected item
> for both
>      comboboxes should be selected if they are still present.
>
>      Fixes #232.

Testing v.1.12.1 (Dec 13 2010, rev: REL-1_12_2) on Windows XP Pro, SP3
To be sure, I downloaded the latest version and upgraded. But there have been no more changes in the meantime.
Connectiontool still does not behave 
 
as expected. I have tried with a couple of different databases an users.

On a closer inspection only the field "Uername" fails. "Database" seems to be filled correctly. So, something has
definitelychanged, but half the fix 
 
does not seem to work as expected.

Steps to reproduce:
- Open query tool
- Select <new connetion> from the connection tool  -->  popup "Connect to Server" appears, "Server", "Database", "User"
arefilled with current values.
 
- Pick a new server --> new values are filled in for database and user.  "Database" behaves as expected: identical name
asin current connection if available on the new server.  "Username" fails, however. Although a user of the same name is
available,some other value is filled in. On the first try some (seemingly random) 
 
username from the list of available users is picked. On subsequent tries it is always the first one on the list.


Regards
Erwin