On 12/09/2010 10:05 AM, Tom Lane wrote:
> I think what we need to do is make fix_dependencies
> build a reverse lookup list of all the objects dependent on each TOC
> object, so that the searching behavior in reduce_dependencies can be
> eliminated outright. That will take O(N) time and O(N) extra space,
> which is a good tradeoff because you won't care if N is small, while if
> N is large you have got to have it anyway.
>
> Barring objections, I will do this and back-patch into 9.0. There is
> maybe some case for trying to fix 8.4 as well, but since 8.4 didn't
> make a separate TOC entry for each blob, it isn't as exposed to the
> problem. We didn't back-patch the last round of efficiency hacks in
> this area, so I'm thinking it's not necessary here either. Comments?
>
>
Sound good. Re 8.4: at a pinch people could probably use the 9.0
pg_restore with their 8.4 dump.
cheers
andrew