Craig Ringer wrote:
> On 11/24/2010 05:18 AM, Magnus Hagander wrote:
>
>> Or you set the handler always, and have the handler only actually
>> create the dump if the directory exists. That way you can add the
>> directory and still get a dump from both existing backends and the
>> postmaster itself without a restart.
>
> That's way smarter. No extra filesystem access during startup, even if
> it is cheap.
I added a commenting referencing this bit to the CF entry so it doesn't
get forgotten. Magnus raised a few other issues in his earlier review
too. Discussion of this patch seems to have jumped the gun a bit into
talking about backpatching before the code for HEAD was completely done,
then stalled there. Are we going to see an updated patch that addresses
submitted feedback in this cycle?
--
Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD
PostgreSQL Training, Services and Support www.2ndQuadrant.us