Hi Guillaume,
I tested it a bit. Your patch solves the issue: open editor, bringing a
cell in editmode, do not change and then close the editor.
- Really editing some values and then pressing 'ESC' does the same as
'Undo' with the new behaviour,
- Really editing a value and the getting editmode from another value or
the same value in the same row does save without query on close
(which is the same behaviour as with a row change).
Regards Steffen
Am 14.09.2010 21:35, schrieb Guillaume Lelarge:
> Le 14/09/2010 13:09, Steffen Kuhn a écrit :
>
>> Hi Guillaume,
>>
>> checking for changed values is what I tried to, but my place was
>> sqlGridEditor::EndEdit because this is already checked there.
>>
> Oh, yeah, I didn't see that. You're right.
>
>
>> But checking here, may be also in OnEditorHidden can be dangerous I think, because of
>> there might be previous changes that might be lost by just disableing 'Save' if one cell has not been changed.
>> This may also happen by doing CancelChange with 'ESC'.
>> I think there will be no other way as comparing the whole row.
>>
>> I would prefer you fixing this, it's to hot for me right now.
>>
>>
> This patch should do it, can you try and test it, please?
>
> Thanks.
>
>
>