Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!)

On 13/09/10 20:43, Jeff Davis wrote:
> On Mon, 2010-09-13 at 09:10 +0300, Heikki Linnakangas wrote:
>>> but we should be consistent and document that:
>>>    (a) it shouldn't happen
>>>    (b) that it's just a sanity check and we're ignoring the race
>>
>> Would this be sufficient?
>>
>> --- a/src/backend/port/unix_latch.c
>> +++ b/src/backend/port/unix_latch.c
>> @@ -156,6 +156,7 @@ OwnLatch(volatile Latch *latch)
>>        if (selfpipe_readfd == -1)
>>            initSelfPipe();
>>
>> +    /* sanity check */
>>        if (latch->owner_pid != 0)
>>            elog(ERROR, "latch already owned");
>>        latch->owner_pid = MyProcPid;
>>
>> Or you want to suggest something better?
>
> Perfect. I was just slightly confused reading it the first time, and I
> think that would have cleared it up.

Ok, added that.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com