Le 27/07/2010 14:12, Dave Page a écrit :
> On Tue, Jul 27, 2010 at 1:10 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 27/07/2010 13:08, Dave Page a écrit :
>>> On Tue, Jul 27, 2010 at 11:16 AM, Guillaume Lelarge
>>> <guillaume@lelarge.info> wrote:
>>>> Le 27/07/2010 11:37, Dave Page a écrit :
>>>>> On Tue, Jul 27, 2010 at 10:30 AM, Guillaume Lelarge
>>>>> <guillaume@lelarge.info> wrote:
>>>>>
>>>>>> Did you fix the script? do you need help? I can probably take some time
>>>>>> to look at it.
>>>>>
>>>>> Not yet. Feel free. It's in commitmsg.py iirc:
>>>>>
>>>>> http://github.com/mhagander/pg_githooks
>>>>>
>>>>
>>>> Well, I could be completely wrong but I think you just need to change
>>>> one parameter in hook/policyenforce.ini: committerequalsauthor must be
>>>> equal to 0. If you do this, the hook won't try to match commiter's and
>>>> author's name, but it will still enforce commiters. Which is what we
>>>> want, right?
>>>
>>> That isn't the problem (and committerequalsauthor is already zero).
>>> The problem is that the commitmsg script sends the email "from" the
>>> author, not the committer.
>>>
>>
>> Oh OK. I thought I still couldn't use the --author CLI option. Now, I
>> understand the issue. I'll try to work on this today.
>
> Well you shouldn't, as it will send email in someone else's name until
> this is fixed.
>
Here is a patch to fix this. Can you try it? Thanks.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com