Re: Unsafe threading in syslogger on Windows

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: Unsafe threading in syslogger on Windows
Дата
Msg-id 4BC833C9.3010804@enterprisedb.com
обсуждение исходный текст
Ответ на Re: Unsafe threading in syslogger on Windows  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Список pgsql-hackers
Heikki Linnakangas wrote:
> Andrew Dunstan wrote:
>> Heikki Linnakangas wrote:
>>> I'm going to see what happens if I remove all the #ifdef WIN32 blocks in
>>> syslogger, and let it use pgpipe() and select() instead of the extra
>>> thread.
>> Sounds reasonable. Let's see how big the changes are on HEAD. I'm not
>> sure it's worth creating a different smaller fix for the back branches.
> 
> I tried that, and got a crash somewhere in the code that inherits the
> syslogger pipe/socket to the child process. I don't understand why, and
> I don't feel like debugging any deeper into that right now. If you or
> someone else wants to give it a shot, that would be good. If not, I
> might try again some other day after sleeping over it.
> 
> Anyway, here's the patch I had in mind for back-branches.

I've committed that patch to all branches now. In the long run it would
be good to get rid of the extra thread, but I'll leave that to someone
else with more Windows skills.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Oleg Bartunov
Дата:
Сообщение: Re: Very ineffective plan with merge join
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: [GENERAL] trouble with to_char('L')