Re: Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>   
>> Tom Lane wrote:
>>     
>>> I'm thinking that the most appropriate fix is to have pg_regress
>>> continue to use -w, but only on Windows.
>>>       
>
>   
>> Well, the filter could be as simple as something like this in the 
>> Makefile for the mingw case:
>>     
>
>   
>>     perl -spi.bak -e 's/(?<!\r)\n$/\r\n/;' expected/*.out
>>     rm expected/*.bak
>>     
>
> I'm not at all thrilled with having the build process intentionally
> modify source files.  Quite aside from messing up the file timestamps,
> what if this is done on a committer's machine?  If the checked-out
> files didn't have CRs, that means his CVS client didn't add them
> and probably won't remove them on checkin.
>
>             
>   

OK, it's a choice of evils. I'm not that unhappy with what you've done.

cheers

andrew