Re: Patches for static check on geo_ops.c

Поиск
Список
Период
Сортировка
От Paul Matthews
Тема Re: Patches for static check on geo_ops.c
Дата
Msg-id 4A970F19.1030706@netspace.net.au
обсуждение исходный текст
Ответ на Re: Patches for static check on geo_ops.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane wrote:
> I've applied the first three of these changes, but not the last two
> (the 'dist' assignments).  "clang" seems to have a tin ear for style :-(.
> It's failing to notice that we have several similar code blocks in
> sequence in these two places, and making the last one different from the
> rest would decrease code readability and modifiability.
>
>   
<voice="Maxwell Smart">"Ah! The old programming via copy-and-paste
trick"</voice>.

Maybe clang's ear for style isn't that bad after all.
:-)


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Josh Berkus
Дата:
Сообщение: Re: 8.5 release timetable, again
Следующее
От: Roger Leigh
Дата:
Сообщение: Re: Unicode UTF-8 table formatting for psql text output