Re: pgsql: Fix a violation of WAL coding rules in the recent patch to

Tom Lane wrote:
> Log Message:
> -----------
> Fix a violation of WAL coding rules in the recent patch to include an
> "all tuples visible" flag in heap page headers.  The flag update *must*
> be applied before calling XLogInsert, but heap_update and the tuple
> moving routines in VACUUM FULL were ignoring this rule.  A crash and
> replay could therefore leave the flag incorrectly set, causing rows
> to appear visible in seqscans when they should not be.  This might explain
> recent reports of data corruption from Jeff Ross and others.

Ouch! Yeah, the old code would write full-page images with the flag
incorrectly set.

Thanks!

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com