Re: COPY WITH CSV FORCE QUOTE * -- REVIEW

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: COPY WITH CSV FORCE QUOTE * -- REVIEW
Дата
Msg-id 4A6A4CED.3010803@dunslane.net
обсуждение исходный текст
Ответ на Re: COPY WITH CSV FORCE QUOTE * -- REVIEW  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>   
>> I have reviewed this and made a small tweak in the docco. I'm just about 
>> ready to commit this, but I'm still slightly worried that passing NULL 
>> to denote all columns in this piece of grammar:
>>     
>
>   
>>             | FORCE QUOTE '*'
>>                 {
>>                     $$ = makeDefElem("force_quote", NULL);
>>                 }
>>     
>
>   
>> might be less than robust - it just feels slightly hacky, so I'd 
>> appreciate others' thoughts.
>>     
>
> I agree, that's ugly.  Why don't you use an A_Star node?
>
>             
>   

OK, Done and committed. Nice little addition.

cheers

andrew


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Sam Mason
Дата:
Сообщение: Re: SE-PostgreSQL Specifications
Следующее
От: KaiGai Kohei
Дата:
Сообщение: Re: SE-PostgreSQL Specifications