Simon Riggs wrote:
>>>
>>> No, because as I said, if archive_command has been returning non-zero
>>> then the archive will be incomplete.
>>>
>> Yes. You think that's wrong? How would you like it to behave, then? I
>> don't think you want the shutdown to wait indefinitely until all files
>> have been archived if there's an error.
>>
>
> The complaint was that we needed to run a manual step to synchronise the
> pg_xlog directory on the standby. We still need to do that, even after
> the patch has been committed because 2 cases are not covered, so what is
> the point of the recent change? It isn't enough. It *might* be enough,
> most of the time, but you have no way of knowing that is the case and it
> is dangerous not to check.
>
If archiving has stalled, it's not a clean shutdown anyway and I
wouldn't expect the wal archive to be automatically complete. I'd still
appreciate a warning that while the shutdown appeared regular, wal
wasn't written completely. But the "corner case" of shutting down a
smoothly running server, the wal archive archive should be complete as well.
Regards,
Andreas