Re: Crash in gist insertion on pathological box data

Поиск
Список
Период
Сортировка
От Teodor Sigaev
Тема Re: Crash in gist insertion on pathological box data
Дата
Msg-id 49D5095C.5050204@sigaev.ru
обсуждение исходный текст
Ответ на Re: Crash in gist insertion on pathological box data  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Crash in gist insertion on pathological box data  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Список pgsql-hackers
> even further.  And what confidence do you have that this change
> eliminates all forms of the problem, anyway?

Yes, I think. Because that part of code ( if (IS_BADRATIO) {...} ) is a corner 
case itself. In example from Andrew, all boxes are placed to one page because of 
floating-point rounding.

We could check IS_BADRATIO again and if it's just put one half of all boxes on 
one page and another half to the another page as it does if all boxes are equal. 
But FPeq() seemed to me a simpler solution and FP* comparisons are widely used 
in geometry.

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [GENERAL] string_to_array with empty input
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: [pgsql-www] Mentors needed urgently for SoC & PostgreSQL Student Internships