Re: pg_hba.conf - patch to report all parsing errors, and then bail

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: pg_hba.conf - patch to report all parsing errors, and then bail
Дата
Msg-id 49B2E6EA.1090402@hagander.net
обсуждение исходный текст
Ответ на Re: pg_hba.conf - patch to report all parsing errors, and then bail  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: pg_hba.conf - patch to report all parsing errors, and then bail
Список pgsql-hackers
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Tom Lane wrote:
>>> It sure looks like that's going to try to free new_parsed_lines more
>>> than once.  Shouldn't clean_hba_list be done just once?
> 
>> Yeah, it should be done in the if branch down below. And I think by our
>> coding standards (or at least by our conventions), the variable should
>> be "ok" and not "OK".
> 
>> Unless there are any objections, I can do those cleanups and apply it.
> 
> I thought the adjacent comments could do with a bit more wordsmithing,
> also, but otherwise that about covers it.

Applied.

//Magnus


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Avoid MSVC breakage caused by my previous commit by not using a
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Out parameters handling