Re: encoding conversion functions versus zero-length inputs

Tom Lane wrote:
> The REL7_4 members of the buildfarm are all red this morning,
> with this symptom in initdb:

Oh dear. I must confess that I didn't test the 7.4 commit, because the 
7.4 branch isn't compiling on my laptop for some reason. Seemed safe 
enough since the changed codepath hadn't been modified between 7.4 and 
later version. I guess I need to fix my 7.4 installation after all...

> My first thought about fixing this was just to alter the check patch to
> pass a length-one instead of length-zero test string, but I now think
> that that's just hiding our heads in the sand; the right fix is to go
> around and make all these palloc's "len * ENCODING_GROWTH_RATE + 1"
> so that they are honestly accounting for the terminating null.  It's
> a bit more tedious but it's the right fix.

Agreed, thanks for the fix.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com