Robert Haas <robertmhaas@gmail.com> writes:
> Yeah, you're right. Attached is a draft patch that tries to clean up
> that and a bunch of other things that you raised.
I've been reviewing this patch, and I had a question: why do we need to
bother with a lockGroupLeaderIdentifier field? It seems totally redundant
with the leader's pid field, ie, why doesn't BecomeLockGroupMember simply
compare leader->pid with the PID it's passed? For some more safety, it
could also verify that leader->lockGroupLeader == leader; but I don't
see what the extra field is buying us.
regards, tom lane