Re: [PATCHES] odd output in restore mode

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [PATCHES] odd output in restore mode
Дата
Msg-id 4946D54E.4060406@hagander.net
обсуждение исходный текст
Ответ на Re: [PATCHES] odd output in restore mode  (Bruce Momjian <bruce@momjian.us>)
Ответы Re: [PATCHES] odd output in restore mode  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers
Bruce Momjian wrote:
> Martin Zaun wrote:
>> 4. Issue: missing break in switch, silent override of '-l' argument?
>>
>> This behaviour has been in there before and is not addresses by the
>> patch: The user-selected Win32 "mklink" command mode is never applied
>> due to a missing 'break' in CustomizableInitialize():
>>
>>      switch (restoreCommandType)
>>      {
>>          case RESTORE_COMMAND_WIN32_MKLINK:
>>              SET_RESTORE_COMMAND("mklink", WALFilePath, xlogFilePath);
>>          case RESTORE_COMMAND_WIN32_COPY:
>>              SET_RESTORE_COMMAND("copy", WALFilePath, xlogFilePath);
>>              break;
> 
> I have added the missing 'break' to CVS HEAD;  thanks.

Why no backpatch to 8.3? Seems like a clear bugfix to me.

//Magnus



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Josh Berkus
Дата:
Сообщение: Re: Sync Rep: First Thoughts on Code
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCHES] odd output in restore mode