Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

> On 14 Jun 2025, at 6:08 PM, David E. Wheeler <david@justatheory.com> wrote:
>
> On Jun 4, 2025, at 11:27, David E. Wheeler <david@justatheory.com> wrote:
>
>> And these should fix the CI failure. I also ran pgindent.
>
> Here’s a quick rebase. I think it’s ready for committer review, but since I’ve poked at it quite a bit myself, I
updatedthe Commitfest item [1] to “Needs Review”. 
>
> Best,
>
> David
>
> [1]: https://commitfest.postgresql.org/patch/5270/
>
> <v9-0001-Rename-jsonpath-method-arg-tokens.patch><v9-0002-Add-additional-jsonpath-string-methods.patch>
>

The basic problem I see with these latest revisions/refactorings is that they fail for pg_upgrade afaict.
Probably this means that some of the rearrangements on the parser/scanner are not that flexible.