Re: bug in pageinspect contrib modul

Поиск
Список
Период
Сортировка
От Zdenek Kotala
Тема Re: bug in pageinspect contrib modul
Дата
Msg-id 49004C90.3080507@sun.com
обсуждение исходный текст
Ответ на Re: bug in pageinspect contrib modul  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Список pgsql-bugs
Heikki Linnakangas napsal(a):
> Zdenek Kotala wrote:
>> The following code is in btreefuncs.c function GetBTPageStatistics:
>>
>> stat->max_avail = BLCKSZ - (BLCKSZ - phdr->pd_special +
>> SizeOfPageHeaderData);
>>
>> I think it should be:
>>
>> stat->max_avail = BLCKSZ - (phdr->pd_special + SizeOfPageHeaderData);
>
> Umm, I don't think so. pd_special is the offset to the start of the
> special area, so (BLCKSZ - pd_special) is the size of the special area.
>
> However, that max_avail field actually looks like dead code, anyway.

Yeah, you are right. I forgot that pd_special does not contain size but offset.

    Thanks Zdenek



--
Zdenek Kotala              Sun Microsystems
Prague, Czech Republic     http://sun.com/postgresql

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Zdenek Kotala
Дата:
Сообщение: Re: Upgrade from 7.4.5 to 8.3.3
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: ftp server symlink