Re: small bug in hlCover

Поиск
Список
Период
Сортировка
От Teodor Sigaev
Тема Re: small bug in hlCover
Дата
Msg-id 48F8CEF9.30507@sigaev.ru
обсуждение исходный текст
Ответ на Re: small bug in hlCover  (Sushant Sinha <sushant354@gmail.com>)
Список pgsql-hackers
Thank you, patch applied.

Sushant Sinha wrote:
> Has any one noticed this?
> 
> -Sushant.
> 
> On Wed, 2008-07-16 at 23:01 -0400, Sushant Sinha wrote:
>> I think there is a slight bug in hlCover function in wparser_def.c
>>
>> If there is only one query item and that is the first word in the text,
>> then hlCover does not returns any cover. This is evident in this example
>> when ts_headline only generates the min_words:
>>
>> testdb=# select ts_headline('1 2 3 4 5 6 7 8 9 10','1'::tsquery,
>> 'MinWords=5');
>>    ts_headline    
>> ------------------
>>  <b>1</b> 2 3 4 5
>> (1 row)
>>
>> The problem is that *q is initialized to 0 which is a legitimate value
>> for a cover. So I have attached a patch that fixes it and after applying
>> the patch here is the result.
>>
>> testdb=# select ts_headline('1 2 3 4 5 6 7 8 9 10','1'::tsquery,
>> 'MinWords=5');
>>          ts_headline         
>> -----------------------------
>>  <b>1</b> 2 3 4 5 6 7 8 9 10
>> (1 row)
>>
>> -Sushant.
> 
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Improving planner variable handling
Следующее
От: Teodor Sigaev
Дата:
Сообщение: Incorrect cursor behaviour with gist index