Re: Block-level CRC checks

Поиск
Список
Период
Сортировка
От Andrew Chernow
Тема Re: Block-level CRC checks
Дата
Msg-id 48E4D622.1010608@esilo.com
обсуждение исходный текст
Ответ на Re: Block-level CRC checks  ("Jonah H. Harris" <jonah.harris@gmail.com>)
Ответы Re: Block-level CRC checks  ("Jonah H. Harris" <jonah.harris@gmail.com>)
Re: Block-level CRC checks  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Jonah H. Harris wrote:
> On Thu, Oct 2, 2008 at 1:29 AM, Jonah H. Harris <jonah.harris@gmail.com> wrote:
>> I ran the regressions and several concurrent benchmark tests which
>> passed successfully, but I'm sure I'm missing quite a bit due to the
>> the fact that it's late, it's just a quick hack, and I haven't gone
>> through the buffer manager locking code in awhile.
> 
> Don't know how I missed this obvious one... should not be coding this
> late @ night :(
> 
> Patch updated.
> 

I read through this patch and am curious why 0xdeadbeef was used as an 
uninitialized value for the page crc.  Is this value somehow less likely 
to have collisons than zero (or any other arbitrary value)?

Would it not be better to add a boolean bit or byte to inidcate the crc 
state?

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Block-level CRC checks
Следующее
От: "Jonah H. Harris"
Дата:
Сообщение: Re: Block-level CRC checks