Re: WAL recovery is broken by FSM patch

Tom Lane wrote:
> I just managed to make a backend dump core while fooling with the CTE
> patch, and found out that the system failed to recover, because the
> ensuing startup process *also* dumped core.  Here's the backtrace:
> ...
> 
> We should of course not be attempting XLogInsert during WAL replay.
> Now smgr_redo knows about that.  I rather wonder why fsm_redo is
> attempting to call smgrtruncate at all, seeing that there's presumably
> smgr's own redo record to tell it to deal with that.  I think that all
> fsm_redo need do is clear out the last untruncated block of FSM.

Agreed. Fixed, thanks.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com