Re: FSM rewrite: doc changes

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: FSM rewrite: doc changes
Дата
Msg-id 48E1D3EA.10501@enterprisedb.com
обсуждение исходный текст
Ответ на Re: FSM rewrite: doc changes  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>> Tom Lane wrote:
>>> In fsm_rebuild_page, surely we needn't check "if (lchild < NodesPerPage)".
> 
>> Yes, we do.
> 
> But the loop starting point is such that you must be visiting a parent
> with at least one child, no?

Hmm, true, and that means that the comment above it is wrong. I'll 
change the code to do what the comment says. That way, if the page is 
completely garbled, and a parent node with no children has a value other 
than zero, that gets fixed too.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Zdenek Kotala
Дата:
Сообщение: Re: [REVIEW] Prototype: In-place upgrade v02
Следующее
От: KaiGai Kohei
Дата:
Сообщение: [BUG] pg_ctl restart at the vanilla v8.3.4