Re: optimizing CleanupTempFiles

Simon Riggs wrote:
> On Thu, 2008-09-18 at 10:19 +0300, Heikki Linnakangas wrote:
>> Simon Riggs wrote:
>>> An unfortunate choice of words! Harmless is not how your average DBA
>>> would describe it when their disk fills and they are apparently unable
>>> to reduce space consumption. So there is still a problem there even if
>>> we fix the temp files portion of it.
>> The files *are* truncated to zero bytes immediately. They're left 
>> hanging as empty files until next checkpoint.
> 
> Ah, cool. So won't actually unlinking temp files be slower than just
> leaving them for checkpointer to clear up offline? i.e. do we really
> need the patch you just posted?

Dunno, maybe. I doubt it's significant either way.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com