Re: optimizing CleanupTempFiles

Simon Riggs wrote:
> On Thu, 2008-09-18 at 09:23 +0300, Heikki Linnakangas wrote:
>> Tom Lane wrote:
>>> Alvaro Herrera <alvherre@commandprompt.com> writes:
>>>> BTW in testing this patch I was surprised by the fact that temp tables
>>>> files are removed at checkpoint time,
>>> [ blink... ]  Doesn't look like that should happen.  What is your
>>> test case?
>> Hmph, must be because of the patch from last winter to prevent 
>> relfilenode reuse until next checkpoint. Looks like we didn't make an 
>> exception for temporary tables. Although it's harmless...
> 
> An unfortunate choice of words! Harmless is not how your average DBA
> would describe it when their disk fills and they are apparently unable
> to reduce space consumption. So there is still a problem there even if
> we fix the temp files portion of it.

The files *are* truncated to zero bytes immediately. They're left 
hanging as empty files until next checkpoint.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com