Re: Dialogs review

Dave Page a écrit :
> On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>
>> Anyways, I attach the new dlgCast.xrc patch file.
>
> That looks pretty sweet, and works well :-). The only thing I note, is
> that even with a bigger gap between controls, the bottom highlight on
> the active control (the blue border on OS X) still isn't shown. If
> that's the case for you as well, then it seems pointless leaving such
> a large gap. Reducing the borders from 8 to 4 looks better here.
>

Reducing the border works here too. To have the blue border on each side
of the control, we need to make the control bigger. For example,
cbSourceType and cbTargetType have 12 for width. With 14, they show the
bottom highlight.

> Thoughts? Aside from that, I think that one is ready to go - and
> should set the standard for the following dialogues :-)
>

There's still one thing that bothers me. The "Use replication" label
seems closer to the left side of the window's border.

And I need to check the border and width changes on Linux and Windows.


--
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com
<?xml version="1.0" encoding="ISO-8859-1"?>
<resource>
  <object class="wxDialog" name="dlgCast">
    <title></title>
    <style>wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME</style>
    <object class="wxFlexGridSizer">
      <cols>1</cols>
      <object class="sizeritem">
        <object class="wxNotebook" name="nbNotebook">
          <object class="notebookpage">
            <label>Properties</label>
            <object class="wxPanel" name="pnlProperties">
              <object class="wxFlexGridSizer">
                <cols>2</cols>
                <rows>8</rows>
                <vgap>5</vgap>
                <hgap>5</hgap>
                <growablerows>6</growablerows>
                <growablecols>1</growablecols>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stName">
                    <label>Name</label>
                    <pos>5,7d</pos>
                  </object>
                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxTextCtrl" name="txtCastname">
                    <pos>70,5d</pos>
                    <size>135,-1d</size>
                  </object>
                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stOID">
                    <label>OID</label>
                    <pos>5,22d</pos>
                  </object>
                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxTextCtrl" name="txtOID">
                    <pos>70,20d</pos>
                    <size>135,-1d</size>
                  </object>
                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stSourceType">
                    <label>Source type</label>
                    <pos>5,37d</pos>
                  </object>
                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="ctlComboBox" name="cbSourceType">
                    <content/>
                    <pos>70,35d</pos>
                    <size>130,14d</size>
                    <style>wxCB_DROPDOWN</style>
                  </object>
                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stTargetType">
                    <label>Target type</label>
                    <pos>5,52d</pos>
                  </object>
                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="ctlComboBox" name="cbTargetType">
                    <content/>
                    <pos>70,50d</pos>
                    <size>130,14d</size>
                    <style>wxCB_DROPDOWN</style>
                  </object>
                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stFunction">
                    <label>Function</label>
                    <pos>5,67d</pos>
                  </object>
                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxComboBox" name="cbFunction">
                    <content/>
                    <pos>70,65d</pos>
                    <size>135,12d</size>
                    <style>wxCB_READONLY|wxCB_DROPDOWN</style>
                  </object>
                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stImplicit">
                    <label>Implicit</label>
                    <pos>5,82d</pos>
                  </object>
                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxCheckBox" name="chkImplicit">
                    <label></label>
                    <pos>70,80d</pos>
                    <size>13,12d</size>
                  </object>
                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stComment">
                    <label>Comment</label>
                    <pos>5,97d</pos>
                  </object>
                  <flag>wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxTextCtrl" name="txtComment">
                    <pos>70,95d</pos>
                    <size>135,83d</size>
                    <style>wxTE_MULTILINE</style>
                  </object>
                  <flag>wxEXPAND|wxALL</flag>
                  <border>4</border>
                </object>
                <object class="sizeritem">
                  <object class="wxStaticText" name="stClusterSet">
                    <label>Use replication</label>
                    <pos>5,183d</pos>
                  </object>
                  <flag>wxALIGN_CENTRE_VERTICAL</flag>
                </object>
                <object class="sizeritem">
                  <object class="wxComboBox" name="cbClusterSet">
                    <content/>
                    <pos>70,181d</pos>
                    <size>135,12d</size>
                    <style>wxCB_READONLY|wxCB_DROPDOWN</style>
                  </object>
                  <flag>wxEXPAND|wxALIGN_TOP|wxALL</flag>
                  <border>4</border>
                </object>
            </object>
            <selected>1</selected>
          </object>
          <pos>2,2d</pos>
          <size>214,415d</size>
        </object>
      </object>
        <flag>wxALL|wxGROW|wxALIGN_CENTRE</flag>
        <border>3</border>
      </object>
      <growablecols>0</growablecols>
      <growablerows>0</growablerows>
      <object class="spacer">
        <size>2,2d</size>
      </object>
      <object class="sizeritem">
        <object class="wxFlexGridSizer">
          <cols>7</cols>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <object class="sizeritem">
            <object class="wxButton" name="wxID_HELP">
              <label>Help</label>
              <pos>135,220d</pos>
            </object>
          </object>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <object class="sizeritem">
            <object class="wxButton" name="wxID_OK">
              <label>&OK</label>
              <default>1</default>
              <pos>135,220d</pos>
            </object>
          </object>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <object class="sizeritem">
            <object class="wxButton" name="wxID_CANCEL">
              <label>&Cancel</label>
              <pos>176,220d</pos>
            </object>
          </object>
          <object class="spacer">
            <size>3,3d</size>
          </object>
          <growablecols>2</growablecols>
        </object>
        <flag>wxTOP|wxLEFT|wxRIGHT|wxGROW</flag>
      </object>
      <object class="spacer">
        <size>3,3d</size>
      </object>
      <object class="sizeritem">
        <object class="unknown" name="unkStatusBar">
          <size>-1,15d</size>
        </object>
        <flag>wxGROW|wxALIGN_CENTRE</flag>
        <border>3</border>
      </object>
    </object>
  </object>
</resource>