Re: Re: [COMMITTERS] pgsql: Repair two places whereSIGTERM exit couldleave shared memory

Heikki Linnakangas wrote:
> Alvaro Herrera wrote:
>> Heikki Linnakangas wrote:
>>> Alvaro Herrera wrote:
>>>> Tom Lane wrote:
>>>>
>>>>> Also use this method
>>>>> for createdb cleanup --- that wasn't a shared-memory-corruption 
>>>>> problem,
>>>>> but SIGTERM abort of createdb could leave orphaned files lying around.
>>>> I wonder if we could use this mechanism for cleaning up in case of
>>>> failed CLUSTER, REINDEX or the like.  I think these can leave dangling
>>>> files around.
>>> They do clean up on abort or SIGTERM.
>>
>> Ah, we're OK then.
> 
> Wait, my memory failed me! No, we don't clean up dangling files on 
> SIGTERM. We should...

No, wait, we do after all. I was fooled by the new 8.3 behavior to leave 
the files dangling until next checkpoint. The files are not cleaned up 
immediately on SIGTERM, but they are at the next checkpoint.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com