Re: A new feature patch and a bug fix

Guillaume Lelarge wrote:
> Dave Page wrote:
>> Index: pgadmin/dlg/dlgProperty.cpp
>> ===================================================================
>> --- pgadmin/dlg/dlgProperty.cpp    (révision 6910)
>> +++ pgadmin/dlg/dlgProperty.cpp    (copie de travail)
>> @@ -432,7 +432,14 @@
>>
>>  void dlgProperty::AddUsers(ctlComboBoxFix *cb1, ctlComboBoxFix *cb2)
>>  {
>> -    FillCombobox(wxT("SELECT usename FROM pg_user ORDER BY usename"),
>> cb1, cb2);
>> +    if (connection->BackendMinimumVersion(8, 1))
>> +    {
>> +        FillCombobox(wxT("SELECT rolname FROM pg_roles ORDER BY 1"),
>> cb1, cb2);
>> +    }
>> +    else
>> +    {
>> +        FillCombobox(wxT("SELECT usename FROM pg_user ORDER BY 1"),
>> cb1, cb2);
>> +    }
>>  }
>>
>
> I'm OK with this.

Please go ahead and commit at your leisure :-)

/D