Re: Proposed patch for contrib/cube

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Proposed patch for contrib/cube
Дата
Msg-id 4766.1153160503@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Proposed patch for contrib/cube  (Joshua Reich <josh@root.net>)
Ответы Re: Proposed patch for contrib/cube  (Joshua Reich <josh@root.net>)
Список pgsql-hackers
Joshua Reich <josh@root.net> writes:
> ... build a cube by specifying 2 arrays, one for the UR 
> coordinate, one for LL.
> I hope people find this useful, and if so, we can add it to contrib/cube.

Seems useful, but it needs work: it will fail on toasted arrays or
arrays containing nulls.  I'd suggest converting it to V1 call protocol
too, as the V1 GETARG macros are the easiest answer to the toasting
problem.  Null array elements are a new issue in CVS HEAD, you'd need
to test against HEAD for that.

As a matter of style, would it be better to error out if the arrays
are not the same length?
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Joshua Reich
Дата:
Сообщение: Proposed patch for contrib/cube
Следующее
От: korry
Дата:
Сообщение: Re: Possible explanation for Win32 stats regression test