> I noticed that Alvaro's comments from [1] have not yet been addressed,
Thanks!
I'm sorry, I missed this comment.
> I'm wary of taking some static functions and making them non-static
...
> For example, perhaps you don't need to expose both StoreRelCheck and
> SetRelationNumChecks, but instead would be better served by exposing
> StoreConstraints? ... Or maybe use AddRelationNewConstraints() ...
I replaced explosion of functions StoreRelCheck + SetRelationNumChecks
to StoreConstraints explosion. Probably function
AddRelationNewConstraints is not very suitable for this ...
[1]
https://www.postgresql.org/message-id/202502031640.zem6orjmmxoz@alvherre.pgsql
--
With best regards,
Dmitry Koval
Postgres Professional: http://postgrespro.com