Re: A bunch of minor issues
От | Heikki Linnakangas |
---|---|
Тема | Re: A bunch of minor issues |
Дата | |
Msg-id | 46FAB502.2020502@enterprisedb.com обсуждение исходный текст |
Ответ на | Re: A bunch of minor issues (Dave Page <dpage@postgresql.org>) |
Ответы |
Re: A bunch of minor issues
|
Список | pgadmin-hackers |
Dave Page wrote: > Heikki Linnakangas wrote: >> There's some strings in calls to wxLogDebug, like "OnTargetComplete() >> called", that are wrapped in _() for translation. Aren't those just for >> developers, and therefore a waste of time to translate? > > Yep. Removed. Here's a few more, though I must admit that translating "Someone created a new line ending style! Run, run for your lives!!" would be much more fun than the run-of-the-mill strings ;-). I also added a XXX-comment to a suspicious piece of code in sysLogger.cpp. It's comparing to a string that's marked for translation, that's apparently coming from the operating system. You might want to change it to a non-translated string or something. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com Index: pgadmin/debugger/dlgDirectDbg.cpp =================================================================== --- pgadmin/debugger/dlgDirectDbg.cpp (revision 6673) +++ pgadmin/debugger/dlgDirectDbg.cpp (working copy) @@ -137,7 +137,7 @@ dbgBreakPointList::Node * node = m_breakpoints.GetFirst(); - wxASSERT_MSG( node != NULL, _( "Expected to find at least one target on the command line" )); + wxASSERT_MSG( node != NULL, wxT( "Expected to find at least one target on the command line" )); dbgBreakPoint * breakpoint = node->GetData(); @@ -153,7 +153,7 @@ case dbgBreakPoint::OID: targetType = 'o'; break; default: { - wxASSERT_MSG( false, _( "Unexpected target type" )); + wxASSERT_MSG( false, wxT( "Unexpected target type" )); break; } } Index: pgadmin/frm/frmQuery.cpp =================================================================== --- pgadmin/frm/frmQuery.cpp (revision 6673) +++ pgadmin/frm/frmQuery.cpp (working copy) @@ -1352,7 +1352,7 @@ break; default: - wxLogError(_("Someone created a new line ending style! Run, run for your lives!!")); + wxLogError(wxT("Someone created a new line ending style! Run, run for your lives!!")); } delete reCRLF; @@ -1396,7 +1396,7 @@ break; default: - wxLogError(_("Someone created a new line ending style! Run, run for your lives!!")); + wxLogError(wxT("Someone created a new line ending style! Run, run for your lives!!")); } if (!changed) Index: pgadmin/utils/sysLogger.cpp =================================================================== --- pgadmin/utils/sysLogger.cpp (revision 6673) +++ pgadmin/utils/sysLogger.cpp (working copy) @@ -207,8 +207,11 @@ #ifdef __WXMAC__ // This one crops up on the Mac and originates from the logging code // for no obviously apparent reason. + + // XXX: Does this need to be translated? What if the OS is running in + // a different language? if (msg.Contains(_("can't flush file descriptor"))) return true; #endif return false; -} \ No newline at end of file +}
В списке pgadmin-hackers по дате отправления:
Предыдущее
От: "Dave Page"Дата:
Сообщение: Re: Patch to add typmod's functions to a type's creation statement
Следующее
От: Heikki LinnakangasДата:
Сообщение: Viewing data of a zero-column table gives an assertion failure