Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids
| От | Joel Jacobson |
|---|---|
| Тема | Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids |
| Дата | |
| Msg-id | 466796f7-be5c-4326-b102-b575f26ce019@www.fastmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids (Michael Paquier <michael@paquier.xyz>) |
| Ответы |
Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids
|
| Список | pgsql-hackers |
On Tue, Apr 27, 2021, at 09:48, Michael Paquier wrote:
On Tue, Apr 27, 2021 at 07:16:25AM +0200, Joel Jacobson wrote:> I've added a test at the end of event_trigger.sql,> reusing the three event triggers already in existence,> just before they are dropped.Cool, thanks. I have been looking at it and I'd still like tocross-check the output data of pg_get_object_address() to see ifpg_identify_object() remains consistent through it. See for examplethe attached that uses a trick based on LATERAL, a bit different thanwhat's done in object_address.sql but that gives the same amount ofcoverage (I could also use two ROW()s and an equality, but well..).
Neat trick, looks good to me.
I've successfully tested fix_event_trigger_pg_identify_object_as_address3.patch.
/Joel
В списке pgsql-hackers по дате отправления: