Hi Peter,
On 3/23/18 10:36 AM, Peter Eisentraut wrote:
> I have committed a basic pg_resetwal test suite as part of another
> patch, so please adjust accordingly.
>
> It looks to me like your pg_resetwal tests contain a bit of useless
> copy-and-paste. For example, you are not using use Config, nor
> $tempdir, and you run $node->stop right after $node->start. Please
> clean that up a bit, or comment, if appropriate.
Yeah, definitely too much copy-paste going on.
The various start/stops were intended the ensure that PG actually starts
with the reset WAL. I see that these tests don't do them, though, so
perhaps that's not a good use of test time.
The pg_rewind tests work for my purposes but it seems worth preserving
the ones I wrote since there is no overlap.
I've attached a patch that integrates my tests with the current tests.
If you don't think they are worth adding then I'll just drop them from
my patchset.
Thanks,
--
-David
david@pgmasters.net