Re: [PATCHES]

John Bartlett wrote:
> The community may wish to comment on the following issue:
>
> 1)    At present the file that will contain the list of ctids is going into
> a new directory called pg_ctids, analogous to pg_twophase, and also stored
> in the pg_data directory.

I don't understand this. What's stored in the file and why? If they're
only needed within the transaction, surely a temp file would be more
appropriate?

The new ctidListStore.c file in the patch is not in a valid diff-format.
I also noticed that you've moved the line beginning with "CREATE_ROLE"
in gram.y so that it's not in alphabetical order anymore.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com