Re: Win32 signals & sockets

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Win32 signals & sockets
Дата
Msg-id 4560.1100650690@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Win32 signals & sockets  ("Magnus Hagander" <mha@sollentuna.net>)
Список pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
> This patch *replaces* the previous one. Contains the exact same changes,
> except it *also* contains the move of the backend parameter file to
> shared memory on win32.

Committed with some small editorializing.  Possibly the weight of my
concern about further dividing the Unix and Win32 cases can be brought
home to you by pointing out that the non-Windows EXEC_BACKEND case had
three different compile failures after applying the patch.

I think the error recovery in the Windows internal_forkexec() routine
is pretty shoddy --- most of the failure paths leak resources of one
variety or another.  Perhaps you can fix that during your upcoming
code refactoring.

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: John Hansen
Дата:
Сообщение: Re: [HACKERS] plperl Safe restrictions
Следующее
От: Neil Conway
Дата:
Сообщение: minor restrpos / markpos optimization