Re: PG qsort vs. Solaris

Поиск
Список
Период
Сортировка
От Zdenek Kotala
Тема Re: PG qsort vs. Solaris
Дата
Msg-id 4522C2CD.105@sun.com
обсуждение исходный текст
Ответ на Re: PG qsort vs. Solaris  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane wrote:
> Neil Conway <neilc@samurai.com> writes:
>> Given the time that has been spent working around
>> the braindamaged behavior of qsort() on various platforms, I would be
>> more inclined to *always* use our qsort() instead of the platform's
>> version.
> 

<snip>

> I propose that we do the following:
> 
> 1. Switch to using port/qsort.c all the time.
  1.5 Move it to another directory - e.g. backend/utils/sort?

> 2. Add a "qsort_arg" function that is identical to qsort except it also
>    passes a void pointer through to the comparison function.  This will
>    allow us to get rid of the non-reentrant static variable and extra
>    level of function call in tuplesort.c.
> 3. Insert a CHECK_FOR_INTERRUPTS() call as was requested back in July.
>    With glibc out of the way, there's no longer a reason to fear memory
>    leakage from cancelling a sort.
  4. replace KR function definition by the ANSI style :-)



regards Zdenek


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Magnus Hagander"
Дата:
Сообщение: Re: [PATCHES] vcbuild bison check
Следующее
От: "Magnus Hagander"
Дата:
Сообщение: Re: [PATCHES] MSVC build broken (again)