Re: DROP FUNCTION IF EXISTS

Found a problem:
ereport(NOTICE,                (errmsg("function %s(%s) does not exist ... skipping",
NameListToString(functionName),                       NameListToString(argTypes))));
 

NameListToString() suppose as an argument List of Value nodes, but
argTypes is a list of TypeName...


Andrew Dunstan wrote:
> Teodor Sigaev wrote:
>> postgres=# drop type if exists foo;
>> NOTICE:  type "foo" does not exist, skipping
>> DROP TYPE
>> postgres=# drop table if exists foo;
>> NOTICE:  table "foo" does not exist, skipping
>> DROP TABLE
>> postgres=# drop function if exists foo();
>> NOTICE:  function foo() does not exist ... skipping
>> DROP FUNCTION
>> postgres=# drop function if exists foo(int);
>> NOTICE:  function foo(
>>                      ^^^ here psql is stopped..
>>
>>
> 
> Yes, this appears to be a bug, not related to encoding etc. Maybe we 
> should be calling func_signature_string in generating this error.
> 
> I will look at it when I get a chance, might be a few days.
> 
> cheers
> 
> andrew

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/