RE: [PATCH] Keeps tracking the uniqueness with UniqueKey
| От | Hou, Zhijie |
|---|---|
| Тема | RE: [PATCH] Keeps tracking the uniqueness with UniqueKey |
| Дата | |
| Msg-id | 44a8eaf67d8a439d949e778dd6279e18@G08CNEXMBPEKD05.g08.fujitsu.local обсуждение исходный текст |
| Ответ на | Re: [PATCH] Keeps tracking the uniqueness with UniqueKey (Andy Fan <zhihui.fan1213@gmail.com>) |
| Ответы |
Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
|
| Список | pgsql-hackers |
Hi
I have a look over this patch and find some typos in 0002.
1.Some typos about unique:
There are some spelling mistakes about "unique" in code comments and README.
Such as: "+However we define the UnqiueKey as below."
2.function name about initililze_uniquecontext_for_joinrel:
May be it should be initialize_ uniquecontext_for_joinrel.
3.some typos in comment:
+ * baserelation's basicrestrictinfo. so it must be in ON clauses.
I think it shoule be " basicrestrictinfo " => "baserestrictinfo".
Besides, I think list_copy can be used to simplify the following code.
(But It seems the type of expr is still in discussion, so this may has no impact )
+ List *exprs = NIL;
...
+ foreach(lc, unionrel->reltarget->exprs)
+ {
+ exprs = lappend(exprs, lfirst(lc));
+ }
Best regards,
В списке pgsql-hackers по дате отправления: