Re: pg_regress breaks on msys
От | Andrew Dunstan |
---|---|
Тема | Re: pg_regress breaks on msys |
Дата | |
Msg-id | 44BE7C6E.5060907@dunslane.net обсуждение исходный текст |
Ответ на | Re: pg_regress breaks on msys (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: pg_regress breaks on msys
(Tom Lane <tgl@sss.pgh.pa.us>)
Re: pg_regress breaks on msys ("Bort, Paul" <pbort@tmwsystems.com>) |
Список | pgsql-hackers |
Tom Lane wrote: >Andrew Dunstan <andrew@dunslane.net> writes: > > >>Tom Lane wrote: >> >> >>>This error message seems pretty thoroughly unhelpful though. Any ideas >>>what it's unhappy about? >>> >>> > > > >>I think we need to change the pg_regress error messages so that it >>includes the command string that failed, at least for now. >> >> > >Done, but I bet it doesn't tell us anything we don't know already. > > Well, we have a result, courtesy of a special run from Stefan: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=seahorse&dt=2006-07-19%2017:52:41 has: Command was: ""C:/msys/1.0/home/pgbuild/pgfarmbuild/HEAD/pgsql.804/src/test/regress/./tmp_check/install/C:/msys/1.0/home/pgbuild/pgfarmbuild/HEAD/inst/bin/initdb" -D"C:/msys/1.0/home/pgbuild/pgfarmbuild/HEAD/pgsql.804/src/test/regress/./tmp_check/data" -L "C:/msys/1.0/home/pgbuild/pgfarmbuild/HEAD/pgsql.804/src/test/regress/./tmp_check/install/C:/msys/1.0/home/pgbuild/pgfarmbuild/HEAD/inst/share/postgresql" --noclean --no-locale >"./log/initdb.log" 2>&1" The second "C:/msys/1.0/" should not be in the path to initdb. Not sure how to fix. cheers andrew > > >>It will be either quoting problem or a vitual path problem, I am pretty >>sure. The old shell script ran in a bourne-shell-like manner. But >>calling system() from a C program will call the Windows command shell, >>where the quoting rules are quite different. >> >> > >In src/include/port.h we have > >/* > * Win32 needs double quotes at the beginning and end of system() > * strings. If not, it gets confused with multiple quoted strings. > * It also requires double-quotes around the executable name and > * any files used for redirection. Other args can use single-quotes. > * > * See the "Notes" section about quotes at: > * http://home.earthlink.net/~rlively/MANUALS/COMMANDS/C/CMD.HTM > */ > >The referenced link seems to be dead :-( but AFAICS the pg_regress code >is following the stated rules. Also, how is it getting past the "make >install" step which is quoting things just the same? Puzzling. > > regards, tom lane > > >
В списке pgsql-hackers по дате отправления: