Re: src/tools/pginclude considered harmful (was Re: [PATCHES]

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: src/tools/pginclude considered harmful (was Re: [PATCHES]
Дата
Msg-id 44B7F090.60906@dunslane.net
обсуждение исходный текст
Ответ на src/tools/pginclude considered harmful (was Re: [PATCHES] toast index entries again)  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: src/tools/pginclude considered harmful (was Re: [PATCHES]  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane wrote:

>In combination with the amount of time wasted over the past two days,
>it is now perfectly clear that the existing pginclude tools are not
>NEARLY good enough to detect what they are breaking.  I would like to
>propose that we revert all the include-related changes of the past two
>days, and that src/tools/pginclude be removed from the CVS tree, until
>such time as it is rewritten to be much smarter about what it is doing.
>
>  
>

I agree with reverting. The tool looks pretty broken anyway, with 
hardcoded paths and all sorts of stuff quite apart from logic problems.

cheers

andrew


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()