Re: contrib/spi makefile inconsistency

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: contrib/spi makefile inconsistency
Дата
Msg-id 4420.1174581210@sss.pgh.pa.us
обсуждение исходный текст
Ответ на contrib/spi makefile inconsistency  (Magnus Hagander <magnus@hagander.net>)
Ответы Re: contrib/spi makefile inconsistency  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-patches
Magnus Hagander <magnus@hagander.net> writes:
> contrib/spi has a Makefile that uses $(addsuffix) makefile rules for
> DATA_built and DOCS. It's the only Makefile in contrib that does it.
> I would like to change that to actually listing the modules instead.

This seems like a definite regression in terms of writing the makefiles.
I'm not very happy about it --- just how much complexity are you saving
in the msvc support?  And have you looked at the other places where
addsuffix is already used?  (It looks like many of the contrib modules
rely on pgxs.mk's usages of addsuffix...)

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] LIKE optimization in UTF-8 and locale-C
Следующее
От: Zdenek Kotala
Дата:
Сообщение: OS timezone files support