Re: contrib/spi makefile inconsistency

Magnus Hagander <magnus@hagander.net> writes:
> contrib/spi has a Makefile that uses $(addsuffix) makefile rules for
> DATA_built and DOCS. It's the only Makefile in contrib that does it.
> I would like to change that to actually listing the modules instead.

This seems like a definite regression in terms of writing the makefiles.
I'm not very happy about it --- just how much complexity are you saving
in the msvc support?  And have you looked at the other places where
addsuffix is already used?  (It looks like many of the contrib modules
rely on pgxs.mk's usages of addsuffix...)

            regards, tom lane