Magnus Hagander wrote:
>>>>I thought we'd more or less dropped that idea based on Andreas'
>>>>responses.
>>>
>>>I've heard no argument against renaming
>>
>>pg_complete_relation_size() to
>>
>>>pg_total_relation_size()
>>
>>Having spent days, no, weeks deciding on that name on list I
>>do not want to see it change this late, especially as we'll
>>now need to go and update pgAdmin again!
Fortunately, pgAdmin doesn't use that function, but only the basic
pg_relation_size(). Phew!
> Also, the change to pg_cancel_backend breaks backwards compatibility
> with 8.0, which is a whole lot worse than breaking it with 8.1-beta1.
Unfortunately, core doesn't see this as backward compatibility break,
instead it's regarded as adjustment of a new function. Anything that's
not in core isn't worth a single thought....
> Also, please do *not* make it return void and elog(ERROR) in the future!
> That will break exactly the above kind of applications in a way that
> cannot be coded around. IIRC this specific scenario was discussed back
> when the function was originally added.
Seems we got around this; call us lucky...
Regards,
Andreas