Re: XADataSource implementation

Поиск
Список
Период
Сортировка
От Oliver Jowett
Тема Re: XADataSource implementation
Дата
Msg-id 4324E15B.5040207@opencloud.com
обсуждение исходный текст
Ответ на XADataSource implementation  (Heikki Linnakangas <hlinnaka@iki.fi>)
Ответы Re: XADataSource implementation  (Heikki Linnakangas <hlinnaka@iki.fi>)
Список pgsql-jdbc
Heikki Linnakangas wrote:
> I've been working on the XADataSource implementation. Patch attached.
> Test case is in the separate zip file, because I couldn't get cvs to
> include it in the diff.

This looks good to me. A few comments:

- we'll need to wrap translatable strings in GT.tr() calls
- there are some places where you compare Xids by identity (==) --
shouldn't these be using .equals()?
- do we really need all of that Base64 encoder/decoder class? Seems like
we could get away with something much more simple.

-O

В списке pgsql-jdbc по дате отправления:

Предыдущее
От: Oliver Jowett
Дата:
Сообщение: Re: TimestampUtils.loadCalendar failes for interval type
Следующее
От: Angelo Neuschitzer
Дата:
Сообщение: Strange behavoir of batches