Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Дата
Msg-id 4259.1458237730@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()  (Teodor Sigaev <teodor@sigaev.ru>)
Список pgsql-committers
Teodor Sigaev <teodor@sigaev.ru> writes:
>> It should go through SetConfigOption(); compare for example
>> tsa_set_curcfg_byname().  Which would also mean you could drop the

> Seems, also show_limit() should use GetConfigOption()?

Nah, that's overkill.  The current contents of similarity_threshold are
always the current state of the GUC variable.  The problem with just
assigning to the variable is that then guc.c doesn't know what you did
and might overwrite the value later.

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Teodor Sigaev
Дата:
Сообщение: Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix assorted breakage in to_char()'s OF format option.