Re: pg_autovacuum/Win32 Fixes
| От | Neil Conway |
|---|---|
| Тема | Re: pg_autovacuum/Win32 Fixes |
| Дата | |
| Msg-id | 41F2273D.2060502@samurai.com обсуждение исходный текст |
| Ответ на | pg_autovacuum/Win32 Fixes ("Dave Page" <dpage@vale-housing.co.uk>) |
| Ответы |
Re: pg_autovacuum/Win32 Fixes
|
| Список | pgsql-patches |
Dave Page wrote:
> Theis patch supercedes *all* my earlier ones from today - apologies for
> the noise, clearly I need a beer or 3 and a few nights away from the
> laptop.
@@ -1166,7 +1166,9 @@
exit(0);
#ifdef WIN32
case 'E':
- args->service_dependencies = optarg;
+ ZeroMemory(deps, sizeof(deps));
+ snprintf(deps, sizeof(deps) - 2, "%s", optarg);
+ args->service_dependencies = (char *)deps;
break;
case 'I':
args->install_as_service++;
After googling around I can see what this code is intended to do; in the
future a comment might be nice. Also, why not strncpy()?
Barring any objections I'll apply this patch to REL8_0_STABLE and HEAD
on Monday.
-Neil
В списке pgsql-patches по дате отправления: