Re: strange result from contrib/seg regression on windows

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: strange result from contrib/seg regression on windows
Дата
Msg-id 4172E7D8.1000403@dunslane.net
обсуждение исходный текст
Ответ на Re: strange result from contrib/seg regression on windows  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>Does anyone have a clue why?
>>    
>>
>
>Evidently your sscanf isn't setting errno for overflow --- look at
>seg_atof() in segparse.y.
>
>
>This code shows several other signs of severe brain death, actually,
>like leaking 256 bytes on each call for an error message buffer that it
>doesn't even need :-(  I'd recommend ripping the whole thing out and
>replacing with a call to float4in.
>
>
>  
>

Yeah. If anyone can do this quickly I'd be grateful. Otherwise it will 
probably be a few days before I get it done.

Alternatively, could we not just use strtof instead of sscanf?

cheers

andrew


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Open Items
Следующее
От: Mark Kirkwood
Дата:
Сообщение: Re: plans for bitmap indexes?