Peter Eisentraut wrote:
> Two comments: First, support for specifying it on configure requires you
> to call AC_ARG_VAR ("require" as in it would prevent people from
> shooting themselves in the foot). Please read up on it and add the
> appropriate call.
Ok, so that makes sure that the var is hooked into the
cache/autoreconfig/etc machinery. Fixed.
> Second, the AC_MSG_NOTICE calls are there for some
> variables because configure may modify them. But LDFLAGS_SL is just
> taken as given, so there is no need to print a notice about it.
Personally I find it annoying when configure eats arguments without any
feedback at all -- did it actually use the parameter, or did I make a
typo? I've removed the AC_MSG_NOTICE anyway.
Updated patch attached.
-O
Index: configure.in
===================================================================
RCS file: /projects/cvsroot/pgsql-server/configure.in,v
retrieving revision 1.380
diff -u -c -r1.380 configure.in
*** configure.in 6 Oct 2004 09:35:19 -0000 1.380
--- configure.in 7 Oct 2004 22:40:42 -0000
***************
*** 532,537 ****
--- 532,538 ----
AC_MSG_NOTICE([using CPPFLAGS=$CPPFLAGS])
AC_MSG_NOTICE([using LDFLAGS=$LDFLAGS])
+ AC_ARG_VAR(LDFLAGS_SL)
AC_PROG_AWK
PGAC_PATH_FLEX
Index: src/Makefile.global.in
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/Makefile.global.in,v
retrieving revision 1.200
diff -u -c -r1.200 Makefile.global.in
*** src/Makefile.global.in 6 Oct 2004 15:14:13 -0000 1.200
--- src/Makefile.global.in 7 Oct 2004 22:40:42 -0000
***************
*** 200,205 ****
--- 200,206 ----
with_gnu_ld = @with_gnu_ld@
ld_R_works = @ld_R_works@
LDFLAGS = @LDFLAGS@
+ LDFLAGS_SL = @LDFLAGS_SL@
LDREL = -r
LDOUT = -o
RANLIB = @RANLIB@
Index: src/Makefile.shlib
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/Makefile.shlib,v
retrieving revision 1.78
diff -u -c -r1.78 Makefile.shlib
*** src/Makefile.shlib 2 Sep 2004 23:06:43 -0000 1.78
--- src/Makefile.shlib 7 Oct 2004 22:40:42 -0000
***************
*** 276,282 ****
# Normal case
$(shlib): $(OBJS)
! $(LINK.shared) $(OBJS) $(SHLIB_LINK) -o $@
# If we're using major and minor versions, then make a symlink to major-version-only.
ifneq ($(shlib), $(shlib_major))
rm -f $(shlib_major)
--- 276,282 ----
# Normal case
$(shlib): $(OBJS)
! $(LINK.shared) $(LDFLAGS_SL) $(OBJS) $(SHLIB_LINK) -o $@
# If we're using major and minor versions, then make a symlink to major-version-only.
ifneq ($(shlib), $(shlib_major))
rm -f $(shlib_major)