Re: [HACKERS] assorted code cleanup
| От | Tom Lane |
|---|---|
| Тема | Re: [HACKERS] assorted code cleanup |
| Дата | |
| Msg-id | 4152.1504810380@sss.pgh.pa.us обсуждение |
| Ответ на | Re: [HACKERS] assorted code cleanup (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>) |
| Ответы |
Re: [HACKERS] assorted code cleanup
|
| Список | pgsql-hackers |
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 9/5/17 15:32, Tom Lane wrote:
>> I do agree with the idea that we should use the * notation in cases where
>> the reader might otherwise think that a plain function was being invoked,
>> ie I don't like
>> some_function_pointer(args);
>> Even if the compiler isn't confused, readers might be. But in the case of
>> structname->pointerfield(args);
>> it's impossible to read that as a plain function call, so I'm okay with
>> dropping the extra punctuation there.
> Committed that way. Thanks.
Is it worth memorializing this in the docs somewhere, perhaps
"53.4. Miscellaneous Coding Conventions" ?
regards, tom lane
В списке pgsql-hackers по дате отправления: